Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[GLUTEN-4660][CH]Asynchronous shuffle read (#4664)" #4767

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Revert "[GLUTEN-4660][CH]Asynchronous shuffle read (#4664)" #4767

merged 1 commit into from
Feb 24, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Feb 24, 2024 •
edited
Loading

This reverts commit bf528b3.

What changes were proposed in this pull request?

Revert #4664, due to performance issue

(Fixes: #ISSUE-ID)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@binmahone binmahone merged commit 7e7fbd2 into apache:main Feb 24, 2024
8 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_24_2024_time.csv log/native_master_02_23_2024_b82359286_time.csv difference percentage
q1 34.34 33.31 -1.021 97.03%
q2 24.77 22.67 -2.103 91.51%
q3 38.78 39.20 0.420 101.08%
q4 37.81 37.79 -0.019 99.95%
q5 71.67 70.31 -1.364 98.10%
q6 5.66 7.14 1.483 126.23%
q7 83.96 84.33 0.373 100.44%
q8 86.74 86.39 -0.345 99.60%
q9 125.66 124.14 -1.513 98.80%
q10 42.79 42.39 -0.395 99.08%
q11 20.56 21.03 0.467 102.27%
q12 28.79 26.45 -2.346 91.85%
q13 45.21 45.22 0.006 100.01%
q14 20.63 16.73 -3.907 81.06%
q15 28.31 27.23 -1.081 96.18%
q16 13.32 14.68 1.360 110.21%
q17 102.37 101.39 -0.980 99.04%
q18 149.07 148.35 -0.722 99.52%
q19 12.59 13.42 0.838 106.66%
q20 26.67 26.61 -0.053 99.80%
q21 226.20 226.57 0.372 100.16%
q22 13.50 13.69 0.197 101.46%
total 1239.39 1229.06 -10.334 99.17%

@baibaichen baibaichen deleted the feature/revert_shuffle branch February 25, 2024 04:44
@baibaichen
Copy link
Contributor Author

版本解释

未包含 #4664

  1. 20240223，23 号定时版本
  2. Revert "[GLUTEN-4660][CH]Asynchronous shuffle read (#4664)" #4767

包含 #4664

  1. 20240224，24 号定时版本
  2. Revert "[GLUTEN-4452] [CH] fix may get wrong hash table when multi jo… #4768

测试结果如下：

20240223 20240224 Revert Shuffle Revert Join
02-23: 02:00 122603 [min]
02-24: 02:00 129294 [min]
02-24: 08:16 128432 [min]
02-24: 08:55 125157 [min] 128473 [min]
02-24: 13:20 124023[min] 128612[min] 118879[min] 129668[min]
02-24: 16:20 124479[min] 128946[min] 121808[min] 126595[min]
02-24: 17:11 124545[min] 128249 [min] 122587[min] 128801[min]

可以看到
未包含 4664 的明显比包含 4664 的快

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binmahone binmahone binmahone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baibaichen @GlutenPerfBot @binmahone